-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Data/Finset/Basic): Depend on less order theory #11732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `Finset.biUnion` and `Finset.disjiUnion` to a new file so that `Data.Finset.Basic` doesn't depend on that much order theory.
16 tasks
fpvandoorn
reviewed
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the text about Finset.biUnion
in the module doc as well.
Please add at least one sentence of doc in Finset.Piecewise
.
fpvandoorn
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
labels
Mar 29, 2024
YaelDillies
added
awaiting-review
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Mar 29, 2024
bors merge |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
labels
Mar 29, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
Move `Finset.biUnion` and `Finset.disjiUnion` to a new file so that `Data.Finset.Basic` doesn't depend on that much order theory.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore(Data/Finset/Basic): Depend on less order theory
[Merged by Bors] - chore(Data/Finset/Basic): Depend on less order theory
Mar 29, 2024
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Move `Finset.biUnion` and `Finset.disjiUnion` to a new file so that `Data.Finset.Basic` doesn't depend on that much order theory.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Move `Finset.biUnion` and `Finset.disjiUnion` to a new file so that `Data.Finset.Basic` doesn't depend on that much order theory.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Move `Finset.biUnion` and `Finset.disjiUnion` to a new file so that `Data.Finset.Basic` doesn't depend on that much order theory.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Move `Finset.biUnion` and `Finset.disjiUnion` to a new file so that `Data.Finset.Basic` doesn't depend on that much order theory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
Finset.biUnion
andFinset.disjiUnion
to a new file so thatData.Finset.Basic
doesn't depend on that much order theory.